Messages in this thread | | | Subject | Re: [PATCH v2] mmc: host: use of_property_read_bool() | From | Sergei Shtylyov <> | Date | Wed, 26 Aug 2015 00:49:56 +0300 |
| |
On 08/26/2015 12:19 AM, Ulf Hansson wrote:
>>>> Use more compact of_property_read_bool() calls instead of the >>>> of_find_property() >>>> calls.
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >>> Thanks, applied for next! >> >> Thanks to you! :-) >> >>> Next, time please run checkpatch to remove errors/warnings. >> >> Hum, I just did and the patch seems clean: >> >> [headless@wasted mmc]$ scripts/checkpatch.pl >> patches/mmc-host-use-of_property_read_bool.patch >> total: 0 errors, 0 warnings, 81 lines checked >> >> patches/mmc-host-use-of_property_read_bool.patch has no obvious style >> problems and is ready for submission. >> >> What do you mean?
> WARNING: Possible unwrapped commit description (prefer a maximum 75 > chars per line) > #12: > Use more compact of_property_read_bool() calls instead of the of_find_property()
> total: 0 errors, 1 warnings, 81 lines checked
> I suspect we might use different versions of the checkpatch script. > Mine is from 4.2rc7.
Tried several variants, the last one was in your repo's 'next' branch (4.2-rc7 based). No warning. :-)
> No worries then!
> Kind regards > Uffe
MBR, Sergei
| |