Messages in this thread | | | Date | Tue, 25 Aug 2015 20:10:14 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv2 2/4] zsmalloc: use page->private instead of page->first_page |
| |
On Tue, Aug 25, 2015 at 11:17:35AM +0900, Sergey Senozhatsky wrote: > On (08/17/15 18:09), Kirill A. Shutemov wrote: > [..] > > @@ -980,7 +979,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags) > > if (i == 1) > > set_page_private(first_page, (unsigned long)page); > > if (i >= 1) > > - page->first_page = first_page; > > + set_page_private(first_page, (unsigned long)first_page); > > This patch breaks zram/zsmalloc. > > Shouldn't it be `page->private = first_page' instead of > `first_page->private = first_page'? IOW: > > - set_page_private(first_page, (unsigned long)first_page); > + set_page_private(page, (unsigned long)first_page); > > ?
Good catch. Thanks!
-- Kirill A. Shutemov
| |