Messages in this thread | | | Subject | Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once | From | Eric Dumazet <> | Date | Tue, 25 Aug 2015 09:00:24 -0700 |
| |
On Tue, 2015-08-25 at 21:17 +0530, Raghavendra K T wrote: > On 08/25/2015 07:58 PM, Eric Dumazet wrote:
> > > > > > This is a great idea, but kcalloc()/kmalloc() can fail and you'll crash > > the whole kernel at this point. > > > > Good catch, and my bad. Though system is in bad memory condition, > since fill_stat is not critical for the system do you think silently > returning from here is a good idea? > or do you think we should handle with -ENOMEM way up.?
Hmm... presumably these 288 bytes could be allocated in inet6_fill_ifla6_attrs() stack frame.
Also it is weird we fill all these stats for a device we just created and never enabled : initial stats are all 0 for them.
| |