lkml.org 
[lkml]   [2015]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/1] params: don't ignore the rest of cmdline if parse_one() fails
On 08/25, Rusty Russell wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
> > On 08/24, Oleg Nesterov wrote:
> >>
> >> I booted the kernel with the additional patch below, and nothing bad has
> >> happened,
> >
> > Until I tried reboot it once with "locktorture.verbose=true" paramater.
> > It didn't boot.
> >
> > This is because parse_args() just aborts after it hits the error, so other
> > arguments at the same initcall level are simply ignored.
> >
> > Fixed by the patch below, but I simply can't believe nobody hit this (imo)
> > bug before.
> >
> > Why does parse_args() do this?? I simply can't understand why parse_args()
> > adds more random and hard-to-understand problems if one of the args ("=true"
> > in this particular case) is wrong.
> >
> > Yes, the patch below is probably oversimplified / incomplete but imho the
> > current behaviour is confusing. At least I was greatly confused ;) At least
> > (I think) it makes sense to let the user know that the rest of command line
> > was probably ignored.
>
> This is nice, but please save and return the error properly; modules need
> this too.

OK, thanks, please see the patch.

> I think nobody hit this before because they notice that they screwed up
> the commandline and it didn't boot.

Yes, I didn't know parse_args() works this way. Besides, I didn't notice
the "invalid for parameter" error message on the serial console, so I
thought that the kernel panic was somehow caused by the patch I tried
to test.

Oleg.



\
 
 \ /
  Last update: 2015-08-25 17:41    [W:0.287 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site