Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v4 13/52] PCI, acpiphp: Add missing realloc list checking after resource allocation | Date | Tue, 25 Aug 2015 00:09:29 +0200 |
| |
On Thursday, August 20, 2015 11:20:28 PM Yinghai Lu wrote: > We check the realloc list, as list must be empty after allocation. > > Add missing one acpiphp driver. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-acpi@vger.kernel.org > --- > drivers/pci/hotplug/acpiphp_glue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index ff53856..1c7c1d7 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -507,6 +507,7 @@ static void enable_slot(struct acpiphp_slot *slot) > } > } > __pci_bus_assign_resources(bus, &add_list, NULL); > + BUG_ON(!list_empty(&add_list));
Is crashing the kernel the best we can do here?
What about bailing out with a WARN_ON() instead? Surely, the kernel can work without the new device?
> > acpiphp_sanitize_bus(bus); > pcie_bus_configure_settings(bus); >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |