Messages in this thread | | | Date | Fri, 21 Aug 2015 10:39:58 -0700 | Subject | Re: [PATCHv4 net-next 10/10] openvswitch: Allow attaching helpers to ct action | From | Pravin Shelar <> |
| |
On Thu, Aug 20, 2015 at 5:47 PM, Joe Stringer <joestringer@nicira.com> wrote: > On 19 August 2015 at 15:57, Pravin Shelar <pshelar@nicira.com> wrote: >> On Tue, Aug 18, 2015 at 4:39 PM, Joe Stringer <joestringer@nicira.com> wrote: >>> Add support for using conntrack helpers to assist protocol detection. >>> The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper >>> to be used for this connection. >>> >>> Example ODP flows allowing FTP connections from ports 1->2: >>> in_port=1,tcp,action=ct(helper=ftp,commit),2 >>> in_port=2,tcp,ct_state=-trk,action=ct(),recirc(1) >>> recirc_id=1,in_port=2,tcp,ct_state=+trk-new+est,action=1 >>> recirc_id=1,in_port=2,tcp,ct_state=+trk+rel,action=1 >>> >>> Signed-off-by: Joe Stringer <joestringer@nicira.com> >>> --- >>> v2-v3: No change. >>> v4: Change error code for unknown helper ENOENT->EINVAL. >> >> I got following compilation warning : >> >> net/openvswitch/conntrack.c:352:42: error: incompatible types in >> comparison expression (different address spaces) > > Is this made available via another sparse flag? It looks like it's > related to the __rcu as you've mentioned below, but I'm not seeing > this (latest sparse, gcc-4.9.2) > You need to enable RCU space checker in kernel config.
| |