Messages in this thread | | | From | Chao Yu <> | Subject | RE: [PATCH 9/9] f2fs: update extent tree in batches | Date | Fri, 21 Aug 2015 20:54:44 +0800 |
| |
Hi Jaegeuk,
> -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Friday, August 21, 2015 1:48 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 9/9] f2fs: update extent tree in batches > > Hi Chao, > > On Wed, Aug 19, 2015 at 07:21:48PM +0800, Chao Yu wrote: > > This patch introduce a new helper f2fs_update_extent_tree_range > > which can update extent nodes in extent tree in batches. > > > > Now, we use the function to invalidate blocks in batches instead of > > invalidating them one by one when truncating blocks. > > IMO, it's not clear the benefit of this patch in terms of performance and code > readability versus risky code changes.
This is only used in truncate path, IMO, in theory, we can gain benefit from this batch mode operation when truncating frequently.
I will test the patch for numbers.
Thanks,
| |