Messages in this thread | | | Subject | Re: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver | From | Jonathan Cameron <> | Date | Sun, 2 Aug 2015 19:35:51 +0100 |
| |
On 02/08/15 17:37, Dan Carpenter wrote: > On Sun, Aug 02, 2015 at 05:32:30PM +0100, Jonathan Cameron wrote: >> On 20/07/15 15:14, Dan Carpenter wrote: >>> On Mon, Jul 20, 2015 at 04:52:30PM +0300, Teodora Baluta wrote: >>>> +static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo, >>>> + int index, int *val) >>>> +{ >>>> + switch (index) { >>>> + case AXIS_X: >>>> + *val = (raw[AXIS_X] - nfo) * 1000 / sens[AXIS_X]; >>>> + break; >>>> + case AXIS_Y: >>>> + *val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y]; >>>> + break; >>>> + case AXIS_Z: >>>> + *val = (raw[AXIS_Z] - nfo) * 1000 / sens[AXIS_Z]; >>>> + break; >>>> + default: >>>> + return -EINVAL; >>>> + } >>>> + >>>> + return 0; >>>> +} >>> >>> We never pass invalid indexes here so this could be replaced with: >>> >>> static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo, >>> int index, int *val) >>> { >>> *val = (raw[index] - nfo) * 1000 / sens[index]; >>> return 0; >> Even better change the function signature and don't return anything at >> all perhaps? >> > > Yeah. Or this: > > static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo, int index) > { > return (raw[index] - nfo) * 1000 / sens[index]; > } > > regards, > dan carpenter *laughs*. Good point ;) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |