lkml.org 
[lkml]   [2015]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe
On Mon, Aug 17, 2015 at 4:18 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sat, Jul 25, 2015 at 8:57 AM, Andy Lutomirski <luto@kernel.org> wrote:
>> This will allow IRQ stacks to nest inside NMIs or similar entries
>> that can happen during IRQ stack setup or teardown.
>>
>> The Xen code here has a confusing comment.
>>
>> The new macros won't work correctly if they're invoked with IRQs on.
>> Add a check under CONFIG_DEBUG_ENTRY to detect that.
>>
>
>> +/*
>> + * Enters the IRQ stack if we're not already using it. NMI-safe. Clobbers
>> + * flags and puts old RSP into old_rsp, and leaves all other GPRs alone.
>> + * Requires kernel GSBASE.
>> + *
>> + * The invariant is that, if irq_count != 1, then the IRQ stack is in use.
>> + */
>
> I might be wrong, but shouldn't be this read as 'if irq_count != -1' ?
>

Indeed. Will fix for the next version.

--Andy


\
 
 \ /
  Last update: 2015-08-19 18:01    [W:0.094 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site