| Date | Wed, 19 Aug 2015 13:50:22 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue |
| |
On Tue, Aug 18, 2015 at 12:58:20PM -0400, Raphaël Beamonte wrote: > Light code refactoring to keep the lines under 80 characters to follow > the kernel code style. >
The first patches seem fine but this one is too hard to review... Divide it up somehow. Maybe:
patch #1: comments patch #2: add line breaks patch #3: add temporary variables patch #4: reverse conditions
I have looked through this patch a little, and I am skepitcal of some of these changes. Do they really improve readability?
- if (TempCCk == priv->cck_txbbgain_table[i].ccktxbb_valuearray[0]) { - priv->cck_present_attentuation_20Mdefault = (u8)i; - break; - } + if (TempCCk != + priv->cck_txbbgain_table[i]. + ccktxbb_valuearray[0]) + continue;
regards, dan carpenter
|