Messages in this thread | | | Date | Tue, 11 Aug 2015 10:46:50 +0800 | From | Jisheng Zhang <> | Subject | Re: [PATCH v2 4/5] ARM: berlin: add a PWM node on the BG2 |
| |
Dear Sebastian,
On Mon, 10 Aug 2015 21:51:44 +0200 Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> On 30.07.2015 11:23, Antoine Tenart wrote: > > This patch adds a PWM node in the Berlin BG2 device tree, using the > > newly added Berlin PWM driver. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > --- > > arch/arm/boot/dts/berlin2.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi > > index ef811de09908..e17bd5faed27 100644 > > --- a/arch/arm/boot/dts/berlin2.dtsi > > +++ b/arch/arm/boot/dts/berlin2.dtsi > > @@ -512,5 +512,11 @@ > > interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; > > }; > > }; > > + > > + pwm: pwm@f20000 { > > + compatible = "marvell,berlin-pwm"; > > + reg = <0xf20000 0x40>; > > + #pwm-cells = <3>; > > + }; > > I only checked berlin2.dtsi: > The top most line with <GIC_SPI 15 ...> belongs to a sub-node of > apb@fc0000 - which means that the pwm node isn't sorted in by > address. Please sort the nodes by address in all three DT patches. > > BTW, is there any IRQ from the PWM IP routed to any intc upstream? > A quick look into some BSP code does not reveal any hints maybe > one of the Marvell guys can comment on it.
There's no interrupt for the PWM in all berlin SoCs ;)
Thanks, Jisheng
| |