Messages in this thread | | | Date | Fri, 10 Jul 2015 11:06:24 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source |
| |
On (07/10/15 10:32), Minchan Kim wrote: > static struct page *isolate_source_page(struct size_class *class) > { > struct page *page; > + int i; > + bool found = false; >
why use 'bool found'? just return `page', which will be either NULL or !NULL?
-ss
> - page = class->fullness_list[ZS_ALMOST_EMPTY]; > - if (page) > - remove_zspage(page, class, ZS_ALMOST_EMPTY); > + for (i = ZS_ALMOST_EMPTY; i >= ZS_ALMOST_FULL; i--) { > + page = class->fullness_list[i]; > + if (!page) > + continue; > > - return page; > + remove_zspage(page, class, i); > + found = true; > + break; > + } > + > + return found ? page : NULL; > }
-ss
| |