lkml.org 
[lkml]   [2015]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Hi,

thanks for the submission!

> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001

BIT(0) maybe?

> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };

Closing '}' should be on seperate line.

And what Mark said.

Other than that, looks okay I'd say.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-07-09 22:21    [W:0.072 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site