Messages in this thread | | | Date | Fri, 31 Jul 2015 21:50:18 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL) |
| |
On 31-07-15, 11:04, Murali Karicheri wrote: > On 07/31/2015 04:38 AM, Viresh Kumar wrote: > >IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > >is no need to do that again from its callers. Drop it. > > > > IS_ERR_OR_NULL() is defined as > > static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) > { > return !ptr || IS_ERR_VALUE((unsigned long)ptr); > } > > So the unlikely() applies only to second part. Wouldn't that be a > problem for optimization?
This is what the first patch of the series does:
http://permalink.gmane.org/gmane.linux.kernel/2009151
-- viresh
| |