lkml.org 
[lkml]   [2015]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/16] x86/efi: Add get and set variable to EFI services pointer table
On Thu, Jul 30, 2015 at 04:19:58PM +0100, Matt Fleming wrote:
> On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote:
> > Add get variable and set variable function to EFI services pointer
> > table for supporting later functions of hibernate signature
> > verification to keep the HMAC key in efi boot service veriable.
> >
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
>
> Maybe mention that we want to be able to read/write variables from
> within the EFI boot stub? That's really why you want to add
> {get,set}_variable pointers.
>

I will add more detail for accessing efi boot service
variable is because that will not touched by unauthenticated
codes.

> s/veriable/variable/
>

I will fix the typo.

> Rest of the patch looks good.
>

Thanks a lot!
Joey Lee


\
 
 \ /
  Last update: 2015-07-31 12:41    [W:0.114 / U:1.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site