lkml.org 
[lkml]   [2015]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.1 189/267] md: unlock mddev_lock on an error path.
    Date
    4.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.de>

    commit 9a8c0fa861e4db60409b4dda254cef5e17e4d43c upstream.

    This error path retuns while still holding the lock - bad.

    Fixes: 6791875e2e53 ("md: make reconfig_mutex optional for writes to md sysfs files.")
    Signed-off-by: NeilBrown <neilb@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/md.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -4005,8 +4005,10 @@ new_dev_store(struct mddev *mddev, const
    else
    rdev = md_import_device(dev, -1, -1);

    - if (IS_ERR(rdev))
    + if (IS_ERR(rdev)) {
    + mddev_unlock(mddev);
    return PTR_ERR(rdev);
    + }
    err = bind_rdev_to_array(rdev, mddev);
    out:
    if (err)



    \
     
     \ /
      Last update: 2015-07-31 23:41    [W:3.365 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site