lkml.org 
[lkml]   [2015]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem
From
On Thu, Jul 30, 2015 at 12:52 PM, Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
> On Fri, Jul 24 2015, Kees Cook <keescook@chromium.org> wrote:
>
>> The esc argument is used to reduce which characters will be escaped.
>> For example, using " " with ESCAPE_SPACE will not produce any escaped
>> spaces.
>>
>
> Yeah, I've been confused by this more than once - the old description
> and the parameter name suggest that the esc string contains additional
> characters to escape, not the other way around.
>
> Could we also rename the parameter 'only' or something like that? In any
> case,

Oh! Yeah, good idea. That would help clarify it even more. I'll send this.

>
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2015-07-30 22:41    [W:0.053 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site