Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem | Date | Thu, 30 Jul 2015 21:52:31 +0200 |
| |
On Fri, Jul 24 2015, Kees Cook <keescook@chromium.org> wrote:
> The esc argument is used to reduce which characters will be escaped. > For example, using " " with ESCAPE_SPACE will not produce any escaped > spaces. >
Yeah, I've been confused by this more than once - the old description and the parameter name suggest that the esc string contains additional characters to escape, not the other way around.
Could we also rename the parameter 'only' or something like that? In any case,
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
| |