Messages in this thread | | | Subject | Re: [Bugfix] x86, irq: Fix regression caused by commit d32932d02e18 | From | Jiang Liu <> | Date | Thu, 30 Jul 2015 17:12:39 +0800 |
| |
On 2015/7/30 17:07, Matt Fleming wrote: > On Thu, 30 Jul, at 03:51:32PM, Jiang Liu wrote: >> Commit d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical >> irqdomain interfaces") introduced a regression when converting IOAPIC >> to hierarchy irqdomain, which sets wrong irq flow handler for IOAPIC >> pins on Surface Pro 3 and causes failure when detecting I2C controllers. >> It's caused by using stale attribute value when setting up IOAPIC pins. >> With this patch applied, all IOAPIC IRQ configuration are identical >> to v4.1 on Surface Pro 3. >> >> Fixes: d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical irqdomain interfaces") >> Reported-by: Matt Fleming <matt@codeblueprint.co.uk> >> Tested-and-reported-by: Chen Yu <yu.c.chen@intel.com> >> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> >> --- >> Hi Matt, >> Could you please help to test this patch? >> Thanks! >> Gerry >> --- >> arch/x86/kernel/apic/io_apic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Works for me! What I actually did was apply this fixup commit ontop of > commit d32932d02e18, just to be sure that it fixes the issue. I'm about > to apply it on top of -rc4 just to be sure. Hi Matt, Chen found there are other issues with 4.2-rc4 which breaks Surface Pro 3's I2C and multitouch drivers. If you run into the same trouble, please contact Chen Yu <yu.c.chen@intel.com> for details:) Thanks! Gerry
| |