lkml.org 
[lkml]   [2015]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/8] clk: add support for clocks provided by SCP(System Control Processor)


On 29/07/15 18:37, Stephen Boyd wrote:
> On 07/23/2015 04:10 AM, Sudeep Holla wrote:
>> On some ARM based systems, a separate Cortex-M based System Control
>> Processor(SCP) provides the overall power, clock, reset and system
>> control. System Control and Power Interface(SCPI) Message Protocol
>> is defined for the communication between the Application Cores(AP)
>> and the SCP.
>>
>> This patch adds support for the clocks provided by SCP using SCPI
>> protocol.
>>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Mike Turquette <mturquette@baylibre.com>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Jon Medhurst (Tixy) <tixy@linaro.org>
>> Cc: linux-clk@vger.kernel.org
>
> Looks good to me, modulo one comment.
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>

Thanks, I assume you are fine if this gets merged via arm-soc

>> +
>> +static const struct of_device_id scpi_clocks_ids[] = {
>> + { .compatible = "arm,scpi-clocks", },
>> + {}
>> +};
>
> Did you want a MODULE_DEVICE_TABLE() here?
>

Yes, I do and it's added now.

Regards,
Sudeep


\
 
 \ /
  Last update: 2015-07-30 18:21    [W:1.115 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site