lkml.org 
[lkml]   [2015]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies
    On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote:
    [...]
    > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
    > index 7d50711..3b7b7c3 100644
    > --- a/drivers/net/xen-netback/netback.c
    > +++ b/drivers/net/xen-netback/netback.c
    > @@ -314,7 +314,7 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb
    > } else {
    > copy_gop->source.domid = DOMID_SELF;
    > copy_gop->source.u.gmfn =
    > - virt_to_mfn(page_address(page));
    > + virt_to_gfn(page_address(page));
    > }
    > copy_gop->source.offset = offset;
    >
    > @@ -1284,7 +1284,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
    > queue->tx_copy_ops[*copy_ops].source.offset = txreq.offset;
    >
    > queue->tx_copy_ops[*copy_ops].dest.u.gmfn =
    > - virt_to_mfn(skb->data);
    > + virt_to_gfn(skb->data);
    > queue->tx_copy_ops[*copy_ops].dest.domid = DOMID_SELF;
    > queue->tx_copy_ops[*copy_ops].dest.offset =
    > offset_in_page(skb->data);

    Reviewed-by: Wei Liu <wei.liu2@citrix.com>

    One possible improvement is to change gmfn in copy_gop to gfn as well.
    But that's outside of netback code.

    Wei.


    \
     
     \ /
      Last update: 2015-07-29 21:11    [W:5.318 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site