lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 13/14] kthread_worker: Add set_kthread_worker_user_nice()
On Tue, Jul 28, 2015 at 04:39:30PM +0200, Petr Mladek wrote:
...
> +/*
> + * set_kthread_worker_user_nice - set scheduling priority for the kthread worker
> + * @worker: target kthread_worker
> + * @nice: niceness value
> + */
> +void set_kthread_worker_user_nice(struct kthread_worker *worker, long nice)
> +{
> + struct task_struct *task = worker->task;
> +
> + WARN_ON(!task);
> + set_user_nice(task, nice);
> +}
> +EXPORT_SYMBOL(set_kthread_worker_user_nice);

kthread_worker is explcitly associated with a single kthread. Why do
we want to create explicit wrappers for kthread operations? This is
encapsulation for encapsulation's sake. It doesn't buy us anything at
all. Just let the user access the associated kthread and operate on
it.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-07-28 20:01    [W:0.214 / U:5.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site