lkml.org 
[lkml]   [2015]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries
On Tue, Jul 28, 2015 at 08:23:04AM -0700, Andy Lutomirski wrote:
> On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > Paravirt thunk functions aren't aligned, which can impact performance
> > and is inconsistent with gcc-generated functions.
> >
> > Align them at 16-byte boundaries to be consistent with gcc functions.
>
> IMO stackvalidate shouldn't warn about this. We've discussed dropping
> the alignment requirement entirely, since it seems to have little
> benefit on modern CPUs.

Stackvalidate didn't actually find this alignment issue. I just noticed
it when fixing the frame pointer issue. If alignment no longer helps
with performance on modern CPUS, it's fine to drop this patch.

--
Josh


\
 
 \ /
  Last update: 2015-07-28 18:01    [W:0.102 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site