Messages in this thread | | | Date | Tue, 28 Jul 2015 13:43:38 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data |
| |
On Tue, 28 Jul, at 12:37:21PM, Lee Jones wrote: > > The driver shouldn't be called that either. > > You are the only one. What makes iTCO 'special'?
I don't know, I didn't write it. It looks like Wim did ~9 years ago, so it must have made sense to him at the time.
> > > > + info = &lpc_chipset_info[priv->chipset]; > > > > + > > > > + pdata->iTCO_version = info->iTCO_version; > > > > > > Lowercase please. > > > > Hmm... but then this line will read, > > > > pdata->itco_version = info->iTCO_version; > > > > I'm not sure that's an improvement. > > Please consider making all of the variable names conform to the > coding standards we normally abide by. You can submit it either as > patch 1 of this set, or independently.
Right, I figured we were fast approaching this rabit hole.
-- Matt Fleming, Intel Open Source Technology Center
| |