Messages in this thread | | | Date | Mon, 27 Jul 2015 09:33:45 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 33/45] clk: sunxi: Include clk.h |
| |
On Mon, Jul 20, 2015 at 11:01:37AM -0700, Stephen Boyd wrote: > On 07/20/2015 01:01 AM, Maxime Ripard wrote: > >Hi Stephen, > > > >On Fri, Jul 10, 2015 at 04:33:31PM -0700, Stephen Boyd wrote: > >>This clock provider uses the consumer API, so include clk.h > >>explicitly. > >> > >>Cc: Chen-Yu Tsai <wens@csie.org> > >>Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > >>Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > >>--- > >> drivers/clk/sunxi/clk-mod0.c | 3 ++- > >> drivers/clk/sunxi/clk-sun8i-mbus.c | 2 +- > >> drivers/clk/sunxi/clk-sun9i-core.c | 2 +- > >> drivers/clk/sunxi/clk-sun9i-mmc.c | 3 ++- > >> drivers/clk/sunxi/clk-sunxi.c | 2 ++ > >> drivers/clk/sunxi/clk-usb.c | 3 ++- > >> 6 files changed, 10 insertions(+), 5 deletions(-) > >> > >>diff --git a/drivers/clk/sunxi/clk-mod0.c b/drivers/clk/sunxi/clk-mod0.c > >>index 9d028aec58e5..39ba5c3d5d3a 100644 > >>--- a/drivers/clk/sunxi/clk-mod0.c > >>+++ b/drivers/clk/sunxi/clk-mod0.c > >>@@ -14,8 +14,9 @@ > >> * GNU General Public License for more details. > >> */ > >>+#include <linux/clk.h> > >> #include <linux/clk-provider.h> > >>-#include <linux/clkdev.h> > >>+#include <linux/slab.h> > >I guess you're adding a bit more that clk.h ;) > > > >Could you sort the headers alphabetically please? > > > > Sure. > > ---8<---- > > From: Stephen Boyd <sboyd@codeaurora.org> > Subject: [PATCH] clk: sunxi: Include clk.h and remove unused clkdev.h includes > > This clock provider uses the consumer API, so include clk.h > explicitly. Also remove clkdev.h in files that aren't using it > and include slab.h when clkdev.h was being used to implicitly > include it. > > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Perfect, thanks!
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |