lkml.org 
[lkml]   [2015]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver
On Mon, Jul 20, 2015 at 04:52:30PM +0300, Teodora Baluta wrote:
> +static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo,
> + int index, int *val)
> +{
> + switch (index) {
> + case AXIS_X:
> + *val = (raw[AXIS_X] - nfo) * 1000 / sens[AXIS_X];
> + break;
> + case AXIS_Y:
> + *val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y];
> + break;
> + case AXIS_Z:
> + *val = (raw[AXIS_Z] - nfo) * 1000 / sens[AXIS_Z];
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return 0;
> +}

We never pass invalid indexes here so this could be replaced with:

static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo,
int index, int *val)
{
*val = (raw[index] - nfo) * 1000 / sens[index];
return 0;
}

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-07-20 16:41    [W:0.073 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site