lkml.org 
[lkml]   [2015]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3] video-lp8788: Delete a check before backlight_device_unregister()
    Date

    > On 2015. 7. 1., at PM 7:30, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
    >
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 1 Jul 2015 12:08:31 +0200
    >
    > The backlight_device_unregister() function tests whether its argument
    > is NULL and then returns immediately.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    It looks good.

    Acked-by: Jingoo Han <jingoohan1@gmail.com>

    > ---
    > drivers/video/backlight/lp8788_bl.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
    > index e418d5b..5d583d7 100644
    > --- a/drivers/video/backlight/lp8788_bl.c
    > +++ b/drivers/video/backlight/lp8788_bl.c
    > @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl)
    > {
    > struct backlight_device *bl_dev = bl->bl_dev;
    >
    > - if (bl_dev)
    > - backlight_device_unregister(bl_dev);
    > + backlight_device_unregister(bl_dev);
    > }
    >
    > static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,
    > --
    > 2.4.5
    >


    \
     
     \ /
      Last update: 2015-07-02 07:21    [W:4.136 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site