Messages in this thread | | | Date | Sun, 19 Jul 2015 02:25:42 +0200 | From | Ralf Baechle <> | Subject | Re: [PATCH 04/16] MIPS: use struct mips_abi offsets to save FP context |
| |
On Sat, Jul 18, 2015 at 08:21:53PM -0400, Paul Gortmaker wrote: > Date: Sat, 18 Jul 2015 20:21:53 -0400 > From: Paul Gortmaker <paul.gortmaker@windriver.com> > To: Paul Burton <paul.burton@imgtec.com> > Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Matthew > Fortune <matthew.fortune@imgtec.com>, Leonid Yegoshin > <Leonid.Yegoshin@imgtec.com>, Michael Ellerman <mpe@ellerman.id.au>, LKML > <linux-kernel@vger.kernel.org>, Richard Weinberger <richard@nod.at>, James > Hogan <james.hogan@imgtec.com>, Andy Lutomirski <luto@amacapital.net>, > Markos Chandras <markos.chandras@imgtec.com>, Ralf Baechle > <ralf@linux-mips.org>, Manuel Lauss <manuel.lauss@gmail.com>, "Maciej W. > Rozycki" <macro@codesourcery.com>, "linux-next@vger.kernel.org" > <linux-next@vger.kernel.org> > Subject: Re: [PATCH 04/16] MIPS: use struct mips_abi offsets to save FP > context > Content-Type: text/plain; charset=UTF-8 > > On Fri, Jul 10, 2015 at 11:00 AM, Paul Burton <paul.burton@imgtec.com> wrote: > > When saving FP state to struct sigcontext, make use of the offsets > > provided by struct mips_abi to obtain appropriate addresses for the > > sc_fpregs & sc_fpc_csr fields of the sigcontext. This is done only for > > the native struct sigcontext in this patch (ie. for O32 in CONFIG_32BIT > > kernels or for N64 in CONFIG_64BIT kernels) but is done in preparation > > for sharing this code with compat ABIs in further patches. > > > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > > --- > > > > arch/mips/kernel/r4k_fpu.S | 151 +++++++++++++++++++++------------------ > > arch/mips/kernel/signal-common.h | 6 ++ > > arch/mips/kernel/signal.c | 85 +++++++++++++++------- > > 3 files changed, 145 insertions(+), 97 deletions(-) > > > > The current version of this in linux-next picked up a booger in transit. > > $ git show 6775b4ea74d5922e5310b7b7a902a8fbe61a0c9d|diffstat > arch/mips/kernel/r4k_fpu.S | 151 ++++++++++++++++++++------------------- > arch/mips/kernel/signal-common.h | 6 + > arch/mips/kernel/signal.c | 85 ++++++++++++++------- > index.html | 16 ++++ > 4 files changed, 161 insertions(+), 97 deletions(-) > > Guessing it happened at Ralf's end.
Yes and I fixed a few hours ago. Should be ok in the next -next.
Ralf
| |