Messages in this thread | | | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs | Date | Thu, 16 Jul 2015 14:05:03 +0300 (EEST) |
| |
Dave Hansen wrote: > On 07/13/2015 09:53 AM, Oleg Nesterov wrote: > > On 07/13, Kirill A. Shutemov wrote: > >> > >> We don't really need ->vm_ops here: MPX VMA can be detected with VM_MPX > >> flag. And vma_merge() will not merge MPX VMA with non-MPX VMA, because > >> ->vm_flags won't match. > > > > Agreed. > > > > I am wondering if something like the patch below (on top of yours) makes > > sense... Not sure, but mpx_mmap() doesn't look nice too, and with this > > change we can unexport mmap_region(). > > These both look nice to me (and they both cull specialty MPX code which > is excellent). I'll run them through a quick test.
Any update?
-- Kirill A. Shutemov
| |