lkml.org 
[lkml]   [2015]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/36] arm64, thp: remove infrastructure for handling splitting PMDs
On 10/07/15 18:41, Kirill A. Shutemov wrote:
> With new refcounting we don't need to mark PMDs splitting. Let's drop
> code to handle this.
>
> pmdp_splitting_flush() is not needed too: on splitting PMD we will do
> pmdp_clear_flush() + set_pte_at(). pmdp_clear_flush() will do IPI as
> needed for fast_gup.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> arch/arm64/include/asm/pgtable.h | 9 ---------
> arch/arm64/mm/flush.c | 16 ----------------
> 2 files changed, 25 deletions(-)
>
> diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
> index bd5db28324ba..37cdbf37934c 100644
> --- a/arch/arm64/include/asm/pgtable.h
> +++ b/arch/arm64/include/asm/pgtable.h
> @@ -274,20 +274,11 @@ static inline pgprot_t mk_sect_prot(pgprot_t prot)
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> #define pmd_trans_huge(pmd) (pmd_val(pmd) && !(pmd_val(pmd) & PMD_TABLE_BIT))
> -#define pmd_trans_splitting(pmd) pte_special(pmd_pte(pmd))
> -#ifdef CONFIG_HAVE_RCU_TABLE_FREE
> -#define __HAVE_ARCH_PMDP_SPLITTING_FLUSH
> -struct vm_area_struct;
> -void pmdp_splitting_flush(struct vm_area_struct *vma, unsigned long address,
> - pmd_t *pmdp);
> -#endif /* CONFIG_HAVE_RCU_TABLE_FREE */
> -#endif /* CONFIG_TRANSPARENT_HUGEPAGE */

Wouldn't this cause a build failure(Untested) ? We need to retain the last line,

#endif /* CONFIG_TRANSPARENT_HUGEPAGE */

isn't it ?


Thanks
Suzuki



\
 
 \ /
  Last update: 2015-07-15 17:41    [W:0.294 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site