Messages in this thread | | | Date | Tue, 14 Jul 2015 11:45:22 -0300 | From | "" <> | Subject | Re: [PATCH] Revert "perf tools: Allow to specify custom linker command" |
| |
Em Tue, Jul 14, 2015 at 02:00:05PM +0000, Alexey Brodkin escreveu: > On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: > > > > But for now to fix cross-building of perf this revert is enough.
> > > Hmm. You are probably right, my build system always exports LD with > > > correct linker for cross builds so perhaps that's why I this "worked" > > > for me when testing. Sorry.
> > So, I think this is an "Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>" > > for the revert, right?
> > > I guess the correct fix would be [1], i.e. there should be some new > > > variable to pass flags to ld command.
> > > Or maybe [2], could we use make "origin" function? If LD is "default", > > > then use "$(CROSS_COMPILE)ld", otherwise use what the user passed?
> > When you guys get to some conclusion, please submit a new patch, for now > > I am taking the revert with the (implied) Acked-by Aaro, ok?
> Please find my patch that both reverts initial Aaro's patch and implements > proper handling of CC, AR and LD substitution here - https://lkml.org/lkml/2015/7/14/149
I saw it, will do.
- Arnaldo
| |