Messages in this thread | | | Date | Wed, 1 Jul 2015 09:05:31 -0400 | From | Vitaly Andrianov <> | Subject | Re: [PATCH] keystone: dts: add psci command definition |
| |
On 07/01/2015 08:41 AM, Mark Rutland wrote: > On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote: >> This commit adds definition for cpu_on, cpu_off and cpu_suspend commands. >> These definitions must match the corresponding PSCI definitions in >> boot monitor. >> >> Signed-off-by: Vitaly Andrianov <vitalya@ti.com> >> --- >> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi >> index c06542b..ab60fca 100644 >> --- a/arch/arm/boot/dts/keystone.dtsi >> +++ b/arch/arm/boot/dts/keystone.dtsi >> @@ -58,6 +58,14 @@ >> <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>; >> }; >> >> + psci { >> + compatible = "arm,psci"; >> + method = "smc"; >> + cpu_suspend = <0x84000001>; >> + cpu_off = <0x84000002>; >> + cpu_on = <0x84000003>; >> + }; > > It would be nice to have this injected automatically by the bootlaoder > when PSCI is present, as that way users of existing systems can upgrade > their DTB and still have things boot. > > Thanks, > Mark. >
So, KS2 kernel doesn't need that commit and has to wait this from u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is just responsible to load and start it, but doesn't know whether PSCI is supported.
In any case you are right. The DTS also doesn't know whether boot- monitor supports PSCI. It is better to make u-boot to fix up the dts. Let's forget about this patch. I'll work on dts fix-up in u-boot.
Thanks, Vitaly
>> + >> soc { >> #address-cells = <1>; >> #size-cells = <1>; >> -- >> 1.9.1 >>
| |