lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] mfd: remove unnecessary check
From
2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Lee Jones wrote:
>> On Tue, 30 Jun 2015, Maninder Singh wrote:
>>
>> > o Making pdata NULL check to (!pdata) as coding statndard
>> > and all other checks in file.
>> > o Removing redundant check of pdata, because we already
>> > check for pdata, and also derefernced before this check
>> >
>> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> > ---
>> > drivers/mfd/t7l66xb.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Applied, with a properly formatted subject line.
>
> Should have probably been more forthcomming with some advice.
>
> Next time, please use `git log --oneline -- <subsystem>` to see what
> the accepted format is.

... and a spell-check could be useful as well :). The reviewed-by tag
was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
so I think it should be dropped.

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2015-07-01 10:21    [W:0.059 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site