lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 4/4] VFIO: platform: Calxeda xgmac reset module
    From
    Date
    On Fri, 2015-06-05 at 17:06 +0200, Eric Auger wrote:
    > --- /dev/null
    > +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c

    > +static int __init vfio_platform_calxedaxgmac_init(void)
    > +{
    > + return 0;
    > +}
    > +
    > +static void __exit vfio_platform_calxedaxgmac_exit(void)
    > +{
    > +}
    > +
    > +module_init(vfio_platform_calxedaxgmac_init);
    > +module_exit(vfio_platform_calxedaxgmac_exit);

    Just a nit: I think it's OK to leave out these functions if they both do
    nothing. See delete_module in kernel/module.c.


    Paul Bolle



    \
     
     \ /
      Last update: 2015-06-06 15:01    [W:4.046 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site