lkml.org 
[lkml]   [2015]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC] pinctrl: pinctrl-imx: implement suspend/resume
From
On Mon, Jun 1, 2015 at 5:12 PM, Stefan Agner <stefan@agner.ch> wrote:

> In some SoC's using the IMX pin controller, the IP looses its state
> when entering lowest power modes. Enhance the driver with suspend/
> resume functions restoring the pin states.

(...)

This is weird:

> + for (i = 0; i < info->ninput_regs; i++)
> + writel(ipctl->input_regs[i], ipctl->base +
> + info->input_regs_offset + i * sizeof(u32 *));

sizeof(u32 *)?

Don't you mean sizeof(u32).

sizeof(u32 *) will be 4 bytes on a 32bit system, 8 bytes on a
64bit system ... but I think your registers are always
32 bits, 4 bytes, apart.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-06-04 10:41    [W:0.050 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site