lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH/RFC 0/3] of/overlay: Update aliases when added or removed
    Date
    On Tue, 30 Jun 2015 16:51:13 +0200
    , Geert Uytterhoeven <geert+renesas@glider.be>
    wrote:
    > Hi,
    >
    > Currently the list of aliases is not updated when a DT overlay that adds
    > an alias is loaded or unloaded. This break drivers (e.g. serial) that
    > rely on of_alias_get_id(). This RFC patch series fixes that.
    >
    > This is definitely not a final solution to be applied, as (1) it doesn't
    > fix all possible cases, and as (2) there's an unresolved issue w.r.t.
    > object lifetime. More about this in the last patch.
    >
    > But it's Good Enough For My Use Case(TM), which is enabling/disabling
    > serial ports on expansion headers by (un)loading DTBOs.
    >
    > Thanks for your comments!
    >
    > Geert Uytterhoeven (3):
    > [RFC] of: Extract of_alias_create()
    > [RFC] of: Add of_alias_destroy()
    > [RFC] of/dynamic: Update list of aliases on aliases changes

    Looks good to me. I've made comments on patch 3. Also, you'll need to
    include unittests before I can merge it.

    g.

    >
    > drivers/of/base.c | 72 +++++++++++++++++++++++++++++++++-------------------
    > drivers/of/dynamic.c | 24 ++++++++++++++++++
    > include/linux/of.h | 3 +++
    > 3 files changed, 73 insertions(+), 26 deletions(-)
    >
    > --
    > 1.9.1
    >
    > Gr{oetje,eeting}s,
    >
    > Geert
    >
    > --
    > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
    >
    > In personal conversations with technical people, I call myself a hacker. But
    > when I'm talking to journalists I just say "programmer" or something like that.
    > -- Linus Torvalds



    \
     
     \ /
      Last update: 2015-06-30 22:41    [W:3.860 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site