lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates
    On Thu, Jun 25, 2015 at 05:37:49AM -0400, Dan Williams wrote:
    > diff --git a/include/linux/compiler.h b/include/linux/compiler.h
    > index 867722591be2..9a528d945498 100644
    > --- a/include/linux/compiler.h
    > +++ b/include/linux/compiler.h
    > @@ -21,6 +21,7 @@
    > # define __rcu __attribute__((noderef, address_space(4)))

    On this side of the #ifdef CONFIG_SPARSE_RCU_POINTER statement then
    __pmem isn't defined so it leads to a build error running a CHECKER on
    today's linux-next.

    I would define __pmem away, but I don't understand why __pmem and
    CONFIG_SPARSE_RCU_POINTER are related at all. Maybe it should be
    outside the if statement?

    > #else
    > # define __rcu
    > +# define __pmem __attribute__((noderef, address_space(5)))
    > #endif
    > extern void __chk_user_ptr(const volatile void __user *);
    > extern void __chk_io_ptr(const volatile void __iomem *);
    > @@ -42,6 +43,7 @@ extern void __chk_io_ptr(const volatile void __iomem *);
    > # define __cond_lock(x,c) (c)
    > # define __percpu
    > # define __rcu
    > +# define __pmem
    > #endif
    >
    > /* Indirect macros required for expanded argument pasting, eg. __LINE__. */

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2015-06-30 12:41    [W:6.114 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site