Messages in this thread | | | Date | Wed, 3 Jun 2015 10:15:09 +0200 | From | Pali Rohár <> | Subject | Re: [PATCH v4 3/3] dell-laptop: Use dell-rbtn instead i8042 filter when possible |
| |
On Tuesday 02 June 2015 20:55:05 Darren Hart wrote: > On Wed, May 27, 2015 at 07:52:13PM -0700, Darren Hart wrote: > > On Wed, May 27, 2015 at 11:28:25PM +0200, Pali Rohár wrote: > > > Until now module dell-laptop registered rfkill device which used i8042 > > > filter function for receiving HW switch rfkill events (handling special > > > keycode). > > > > > > But for some dell laptops there is native ACPI driver dell-rbtn which can > > > receive rfkill events (without i8042 hooks). > > > > > > So this patch will combine best from both sides. It will use native ACPI > > > driver dell-rbtn for receiving events and dell-laptop SMBIOS interface for > > > enabling or disabling radio devices. If ACPI driver or device will not be > > > available fallback to i8042 filter function will be used. > > > > > > Patch also changes module_init() to late_initcall() to ensure that init > > > function will be called after initializing dell-rbtn.c driver. > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > Tested-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > > Signed-off-by: Darren Hart <dvhart@linux.intel.com> > > > > > > Several basic checkpatch.pl errors in this one. Please always run checkpatch.pl > > before submitting patches, these sorts of issues should be caught before hitting > > the mailing list. > > > > Please provide some details on the scenarios you have tested to verify you have > > addressed the build and runtime issues reported. > > > > Checking in so this doesn't fall through the cracks. Do you have a v5 in the > works for the 4.2 merge window? > > Thanks, >
In last days I did not have time to look at it... When do you need to see v5 if it could go to 4.2?
-- Pali Rohár pali.rohar@gmail.com
| |