lkml.org 
[lkml]   [2015]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] keys: Delete an unnecessary check before the function call "key_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 26 Jun 2015 16:10:54 +0200

    The key_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    fs/ext4/crypto_key.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
    index 442d24e..f8d15ae 100644
    --- a/fs/ext4/crypto_key.c
    +++ b/fs/ext4/crypto_key.c
    @@ -89,8 +89,7 @@ void ext4_free_crypt_info(struct ext4_crypt_info *ci)
    if (!ci)
    return;

    - if (ci->ci_keyring_key)
    - key_put(ci->ci_keyring_key);
    + key_put(ci->ci_keyring_key);
    crypto_free_ablkcipher(ci->ci_ctfm);
    kmem_cache_free(ext4_crypt_info_cachep, ci);
    }
    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-26 16:41    [W:4.054 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site