Messages in this thread | | | Subject | Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox. | From | Paul Bolle <> | Date | Thu, 25 Jun 2015 09:31:31 +0200 |
| |
On Thu, 2015-06-25 at 08:55 +0200, Michal Simek wrote: > On 06/24/2015 10:36 PM, Paul Bolle wrote: > > On Tue, 2015-06-23 at 11:00 -0700, Moritz Fischer wrote: > > > +MODULE_ALIAS("platform:xilinx-mailbox"); > > > > So I think this MODULE_ALIAS() is only useful if, in short, there's > > a corresponding platform_device created. Ie, a platform_device with > > a name "xilinx-mailbox" that will fire of a "MODALIAS=platform:xili > > nx-mailbox" when it's created. > > > > I couldn't spot such a platform_device. Provided git grep didn't > > let me down here: what breaks if this line is dropped? > > IRC you don't need to have this platform_device in the kernel > present. Only one thing which should be check is that this driver can > be used as platform device driver. > > The only one problematic part is devm_clk_get() and this should be > checked if you can use this as platform driver. From the first look > it looks like that this will break it. > > Anyway if Moritz is able to use this a platform driver he can keep > this line there. If not, it should be removed.
But, assuming this works as a platform driver, where does the "xilinx -mailbox" platform device originate?
Paul Bolle
PS Evolution 3.16 is nearly unbearable in its handling of replies to plain text messages. Doe anyone know how to make it handle them sensibly?
| |