lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8
On Thu, Jun 25, 2015 at 08:58:04AM +0200, Paul Bolle wrote:
> On Wed, 2015-06-24 at 10:57 +0800, Alex Hung wrote:
> > --- /dev/null
> > +++ b/drivers/platform/x86/asus-rbtn.c
>
> > +MODULE_ALIAS("acpi*:ATK4001:*");
>
> This looked odd. It turned out this is the pattern that
> scripts/mod/file2alias.c::do_acpi_entry() creates.
>
> > +static const struct acpi_device_id asusrb_ids[] = {
> > + {"ATK4001", 0},
> > + {"", 0},
> > +};
>
> I think you should just put
> MODULE_DEVICE_TABLE(acpi, asusrb_ids);
>
> here, like all other drivers do, and drop the odd looking alias.
>
> All others drivers except drivers/platform/x86/hp-wireless.c, that is.
> (I noticed that you also wrote that driver.) It should just use
> MODULE_DEVICE_TABLE() too

Thanks for digging in to that, it raised an eyebrow for me as well, but I didn't
dig into it after finding at least one other instance of it.... :-)

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-06-25 22:21    [W:0.163 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site