Messages in this thread | | | Date | Thu, 25 Jun 2015 13:40:21 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 3/3] sched/numa: Fix numabalancing stats in /proc/pid/sched |
| |
On 06/25/2015 01:21 PM, Srikar Dronamraju wrote: > Commit 44dba3d5d6a1 (sched: Refactor task_struct to use numa_faults > instead of numa_* pointers) modified the way tsk->numa_faults stats are > accounted. However that commit never touched show_numa_stats() that > displays /proc/pid/sched. Now the numbers displayed in /proc/pid/sched > dont match the actual numbers. > > Fix it by making sure that /proc/pid/sched reflects the task fault numbers > Also add group fault stats too. > > Also couple of more modifications are added here. > 1. Format change. > - Previously we would list two entries per node, one for private and one for > shared. Also the home node info was listed in each entry. > > - Now preferred node, total_faults and current node are displayed separately. > - Now there is one entry per node, that lists private,shared task and group > faults. > > 2. p->numa_pages_migrated was getting reset after every read of > /proc/pid/sched. Its more useful to have absolute numbers since > differential migrations between two accesses can be easily calculated. > > Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Rik van Riel <riel@redhat.com>
Thank you for updating the statistics to match what the code does nowadays.
| |