lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf header: Delete an unnecessary check before the function call "free_event_desc"
Em Thu, Jun 25, 2015 at 06:22:18PM +0200, SF Markus Elfring escreveu:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 25 Jun 2015 17:12:32 +0200
>
> The free_event_desc() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.

Thanks, applying.

- Arnaldo

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> tools/perf/util/header.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 21a77e7..03ace57 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -1063,8 +1063,7 @@ out:
> free(buf);
> return events;
> error:
> - if (events)
> - free_event_desc(events);
> + free_event_desc(events);
> events = NULL;
> goto out;
> }
> --
> 2.4.4


\
 
 \ /
  Last update: 2015-06-25 19:01    [W:0.911 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site