Messages in this thread | | | Date | Thu, 25 Jun 2015 10:45:05 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 12/13] perf thread_map: Change map entries into a struct |
| |
Em Thu, Jun 25, 2015 at 10:38:41AM +0200, Jiri Olsa escreveu: > On Tue, Jun 23, 2015 at 06:47:26PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Jiri Olsa <jolsa@kernel.org> > > > > We need to store command names with the pid. Changing map entries to be > > a struct holding pid. Process name is coming in shortly. > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Cc: Andi Kleen <ak@linux.intel.com> > > Cc: David Ahern <dsahern@gmail.com> > > Cc: Namhyung Kim <namhyung@kernel.org> > > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Cc: Stephane Eranian <eranian@google.com> > > Link: http://lkml.kernel.org/r/1435012588-9007-2-git-send-email-jolsa@kernel.org > > [ Split providing the set/get accessors from transforming the entries structs ] > > the comment in [] is wrong.. > > and you missed following hunk: > > --- > static struct thread_map *thread_map__realloc(struct thread_map *map, int nr) > { > - size_t size = sizeof(*map) + sizeof(pid_t) * nr; > + size_t size = sizeof(*map) + sizeof(struct thread_map_data) * nr; > --- > > shouldn't be fatal, it probably has the same or biggger size ATM > I'll include the fix in the next version
Yeah, sorry about that, should have noticed that, but as you said, code wise it is harmless.
- Arnaldo
| |