lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] ARM-kernel: Delete an unnecessary check before the function call "smp_set_ops"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 25 Jun 2015 15:00:17 +0200

    The smp_set_ops() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/arm/kernel/setup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
    index e6d8c76..9ac786d 100644
    --- a/arch/arm/kernel/setup.c
    +++ b/arch/arm/kernel/setup.c
    @@ -977,7 +977,7 @@ void __init setup_arch(char **cmdline_p)
    if (!mdesc->smp_init || !mdesc->smp_init()) {
    if (psci_smp_available())
    smp_set_ops(&psci_smp_ops);
    - else if (mdesc->smp)
    + else
    smp_set_ops(mdesc->smp);
    }
    smp_init_cpus();
    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-25 15:41    [W:4.018 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site