Messages in this thread | | | Date | Thu, 25 Jun 2015 06:33:31 -0700 (PDT) | Subject | Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect() | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Thu, 25 Jun 2015 15:10:32 +0200
> net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: > net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized in this function > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > This may be a false positive, but the state machine in > __skb_flow_dissect() is a bit hard to follow. > As I believe it is controlled by a packet received from the network, the > only safe thing to do is to pre-initialize ip_proto.
Actually I think this is a real bug, because for the ETH_P_MPLS_* cases I cannot see what will always set ip_proto before it gets used as an input.
| |