lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/2] ARM-OMAP2+: Delete an unnecessary check before the function call "of_node_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 25 Jun 2015 13:05:28 +0200

    The of_node_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/arm/mach-omap2/timer.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
    index cac46d8..15448221 100644
    --- a/arch/arm/mach-omap2/timer.c
    +++ b/arch/arm/mach-omap2/timer.c
    @@ -208,8 +208,7 @@ static void __init omap_dmtimer_init(void)
    /* If we are a secure device, remove any secure timer nodes */
    if ((omap_type() != OMAP2_DEVICE_TYPE_GP)) {
    np = omap_get_timer_dt(omap_timer_match, "ti,timer-secure");
    - if (np)
    - of_node_put(np);
    + of_node_put(np);
    }
    }

    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-25 14:01    [W:4.024 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site