lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] s390/process: Delete an unnecessary check before the function call "kfree"


    Am 24.06.2015 22:48, schrieb SF Markus Elfring:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 24 Jun 2015 22:40:30 +0200
    >
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > arch/s390/kernel/process.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
    > index dc5edc2..22e6448 100644
    > --- a/arch/s390/kernel/process.c
    > +++ b/arch/s390/kernel/process.c
    > @@ -81,8 +81,7 @@ void release_thread(struct task_struct *dead_task)
    >
    > void arch_release_task_struct(struct task_struct *tsk)
    > {
    > - if (tsk->thread.vxrs)
    > - kfree(tsk->thread.vxrs);
    > + kfree(tsk->thread.vxrs);
    > }
    >
    > int copy_thread(unsigned long clone_flags, unsigned long new_stackp,

    maybe the intention was to check tsk != NULL ?

    re,
    wh


    \
     
     \ /
      Last update: 2015-06-25 12:21    [W:4.019 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site