lkml.org 
[lkml]   [2015]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct
On 06/23, Kirill A. Shutemov wrote:
>
> On Tue, Jun 23, 2015 at 08:02:51PM +0200, Oleg Nesterov wrote:
> > vma->vm_ops->mremap() looks more natural and clean in move_vma(),
> > and this way ->mremap() can have more users. Say, vdso.
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> > ---
> > fs/aio.c | 25 ++++++++++++++++---------
> > include/linux/fs.h | 1 -
> > include/linux/mm.h | 1 +
> > mm/mremap.c | 4 ++--
>
> Please, update Documentation/filesystems/Locking.

OK, thanks, will do.

> > -static int aio_ring_remap(struct file *file, struct vm_area_struct *vma)
> > +static int aio_ring_remap(struct vm_area_struct *vma)
>
> I guess aio_ring_mremap() would be a better name.

Yes, agreed.

OK, I'll wait for other comments then send v2 with these changes.

Oleg.



\
 
 \ /
  Last update: 2015-06-23 20:41    [W:0.117 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site