Messages in this thread | | | Date | Tue, 23 Jun 2015 20:26:55 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct |
| |
On 06/23, Kirill A. Shutemov wrote: > > On Tue, Jun 23, 2015 at 08:02:51PM +0200, Oleg Nesterov wrote: > > vma->vm_ops->mremap() looks more natural and clean in move_vma(), > > and this way ->mremap() can have more users. Say, vdso. > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > --- > > fs/aio.c | 25 ++++++++++++++++--------- > > include/linux/fs.h | 1 - > > include/linux/mm.h | 1 + > > mm/mremap.c | 4 ++-- > > Please, update Documentation/filesystems/Locking.
OK, thanks, will do.
> > -static int aio_ring_remap(struct file *file, struct vm_area_struct *vma) > > +static int aio_ring_remap(struct vm_area_struct *vma) > > I guess aio_ring_mremap() would be a better name.
Yes, agreed.
OK, I'll wait for other comments then send v2 with these changes.
Oleg.
| |