Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising | From | Konrad Rzeszutek Wilk <> | Date | Tue, 23 Jun 2015 07:57:43 -0400 |
| |
On June 23, 2015 2:23:59 AM EDT, Jan Beulich <JBeulich@suse.com> wrote: >>>> On 22.06.15 at 15:56, <konrad.wilk@oracle.com> wrote: >> --- a/drivers/block/xen-blkfront.c >> +++ b/drivers/block/xen-blkfront.c >> @@ -1951,6 +1951,8 @@ static void blkback_changed(struct >xenbus_device *dev, >> >> switch (backend_state) { >> case XenbusStateInitWait: >> + if (dev->state != XenbusStateInitialising) >> + break; > >If, as you say in a subsequent reply, all other drivers already have >such a check, wouldn't it make more sense to put this into xenbus' >backend_changed() or even xenbus_otherend_changed()?
Good idea. Let me spin an cleanup patch for the race handling - but put this in the Jens branch as the merge window is happening right now.
> >Jan
| |